FlexMeasures / flexmeasures / 25024028589

81%

push

github

Check read permissions for regressor sensors when triggering forecasts (#2096)

* Initial plan

* Check read permissions for regressors in trigger_forecast endpoint

Agent-Logs-Url: https://github.com/FlexMeasures/flexmeasures/sessions/9b3ff676-cf08-4d79-8cd1-657ef1581d40

Co-authored-by: BelhsanHmida <149331360+BelhsanHmida@users.noreply.github.com>

* Remove defensive None guard (schema already validates sensor IDs), simplify asset type name

Agent-Logs-Url: https://github.com/FlexMeasures/flexmeasures/sessions/9b3ff676-cf08-4d79-8cd1-657ef1581d40

Co-authored-by: BelhsanHmida <149331360+BelhsanHmida@users.noreply.github.com>

* Align regressor permission check with PR #1071 decorator pattern

Agent-Logs-Url: https://github.com/FlexMeasures/flexmeasures/sessions/564ced47-b413-4ca8-a7d4-3b064d6d8e43

Co-authored-by: BelhsanHmida <149331360+BelhsanHmida@users.noreply.github.com>

* feat: Allow custom error messages in invalid_sender function.

Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>

* feat: surface custom forbidden API messages

Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>

* feat: label multi-context auth failures

Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>

* feat: preserve regressor field access context

Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>

* test: assert unreadable regressor details

Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>

* feat: be robust against error handler not accepting the message argument

Signed-off-by: F.N. Claessen <claessen@seita.nl>

* feat: log sensor ID and culprit field

Signed-off-by: F.N. Claessen <claessen@seita.nl>

* style: capitalize ID

Signed-off-by: F.N. Claessen <claessen@seita.nl>

* refactor: space :)

Signed-off-by: F.N. Claessen <claessen@seita.nl>

* test: split forecasting tests by db scope

Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>

* Update flexme... (continued)

44 of 49 new or added lines in 5 files covered. (89.8%)

12434 of 15614 relevant lines covered (79.63%)

0.8 hits per line