futpib / slopd / 25015266732

85%

master: 85%

push

github

fix: stop disowning live panes by reconcile false-positive; ps reads managed_panes

Two changes that together restore consistency between slopctl ps and what
Send/Interrupt/Tag/Kill will actually accept:

1. reconcile_panes verifies per-pane before declaring death.  When the
   session-scoped list-panes call returns without a managed pane, query its
   options directly via `show-options -t %X -p` (pane IDs are global to the
   tmux server, so this works even when the session is missing).  Only
   disown when tmux confirms the pane is gone (stderr: "no such pane:" /
   "can't find pane:") or its @slopd_managed option has been cleared; on
   ambiguous errors keep the pane and let the next tick retry.  Permanent
   disowning of a live pane (the production failure mode) is far worse than
   a one-tick delay in cleaning up a dead one.

2. list_panes iterates the in-memory managed_panes set instead of
   `tmux list-panes -s -t slopd`.  managed_panes is what
   Send/Interrupt/Tag/Kill check; iterating it makes ps stay in sync with
   those operations.  Per-pane metadata (activity, cwd, slopd opts) still
   comes from tmux via display-message and show-options; panes that have
   died in tmux but are still in managed_panes are skipped (the next
   reconcile tick cleans them up).

36 of 37 new or added lines in 1 file covered. (97.3%)

3084 of 3626 relevant lines covered (85.05%)

1184704.67 hits per line