Alan-Jowett / sonde / 25014929020

82%

Build Type

push

github

Committed by web-flow

Commit Message

Apply maintenance audit drift fixes (#809)

* Apply maintenance audit drift fixes

Detected 14 drift findings: 8 fix-impl, 4 fix-spec, 2 deferred.

Restore pairing storage abstraction and protected persistence, fix node chunk retry handling, repair modem and gateway regressions, add protocol/admin/e2e coverage, and align protocol, pairing, and node documentation.

Deferred: BLE UUID replacement (F-002) and KiCad IR scope mismatch (F-009).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* Fix release clippy for admin integration tests

Guard minimal_program_cbor with debug_assertions so release clippy does not see an unused helper when its only call sites are compiled out.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* Address PR review comments

Bound protected PSK blob decoding, zeroize protected intermediates, avoid panics in MockPairingStore trait methods, correct MockPairingStore design docs, and stop reporting spurious modem reconnects in the in-memory serial test transport.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* Fix rustfmt drift in pairing store

Apply the formatting change required by cargo fmt --check --all after the PR review follow-up edits.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* Address follow-up PR review comments

Bound stale-frame GET_CHUNK retries per attempt, document and enforce cumulative RecordedNodeTransport semantics, and align the on-disk pairing store schema comment with the migration behavior.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* Fix rustfmt drift in harness and wake cycle

Apply the formatting changes requ... (continued)

Coverage Stats

461 of 476 new or added lines in 4 files covered. (96.85%)

1 existing line in 1 file now uncovered.

28154 of 34156 relevant lines covered (82.43%)

231.88 hits per line