Gallopsled / pwntools / 25003092376

74%

Build Type

push

github

Committed by web-flow

Commit Message

Start to check type hints gradually (#2714)

* Start to gradually add type hints

Use mypy-baseline to ignore all existing errors for now while avoiding adding new ones in new code.

* Remove Python 2 fallback imports

* Remove py2compat layer

* Avoid redefining a tube helper function

* Remove explicit new-style class (object) syntax

old-style classes were removed in Python 3 so there is no distinction anymore.

* Ignore type error in shellcraft helper script

* Fix repeatedly changing `linux_dirent.d_name`

* Avoid typechecking windows_termcap on Linux

We run mypy on Linux in CI, ignore Windows related import errors

* Run mypy-baseline in CI

* Add type hint plan to CONTRIBUTING

* Sort the mypy baseline

Run with `--sort-baseline` for better diffs.

`mypy | mypy-baseline sync --sort-baseline`

* Switch dev dependencies to dependency-groups

The dependency groups aren't baked into build metadata and won't appear on Pypi.

Coverage Stats

3906 of 6564 branches covered (59.51%)

64 of 66 new or added lines in 32 files covered. (96.97%)

5 existing lines in 3 files now uncovered.

13427 of 18201 relevant lines covered (73.77%)

0.74 hits per line