stacklok / toolhive / 25001948671

67%

Build Type

push

github

Committed by web-flow

Commit Message

Rename pkg/oauth to pkg/oauthproto and move DCR primitives (#5036)

Implements Phase 1 of issue #4977:
- Rename pkg/oauth/ -> pkg/oauthproto/; update all 17 import sites
  (8 with alias can now drop the alias since pkg name matches)
- Move DCR types, ScopeList, RegisterClientDynamically, and helpers
  from pkg/auth/oauth/dynamic_registration.go into pkg/oauthproto/dcr.go
- RegisterClientDynamically now takes *http.Client directly (nil builds
  a default); drop registerClientDynamicallyWithClient and HTTPClient iface
- Relocate IsLocalhost logic into pkg/oauthproto/IsLoopbackHost; pkg/networking
  keeps its IsLocalhost as a thin wrapper to avoid touching all callers
- Move UserAgent constant from pkg/auth/oauth/oidc.go to pkg/oauthproto/constants.go
- Generalize handleHTTPResponse error string (remove CLI-flag hints)
- Host NewDynamicClientRegistrationRequest in pkg/auth/discovery/dcr_request.go
  (sole caller; loopback redirect-URI assumption stays out of protocol pkg)
- Add tests in pkg/oauthproto/dcr_test.go covering the moved behaviour
- Update pkg/oauthproto/doc.go to document the expanded surface area

Address code review feedback

Fixed issues from code review:
- CRITICAL: Delete orphaned pkg/oauth/ directory (7 files); no importers remain
- HIGH: Copy request in RegisterClientDynamically before validateAndSetDefaults
  to avoid mutating the caller's struct; nil guard moved up before the deref
- HIGH: Drop redundant oauthproto alias from 4 test files (token_test.go,
  oidc_test.go, discovery_test.go, upstream/oidc_test.go)
- MEDIUM: Remove isLoopbackHost private wrapper; dcr.go calls IsLoopbackHost directly
- MEDIUM: Replace 13-line Apache header in pkg/oauthproto/doc.go with 2-line SPDX
- MEDIUM: Add comment in registerDynamicClient clarifying CLI-flag hint is
  intentional; reference #4978 for future structured error handling

Address second round of code review feedback

Fixed issues from code review:
- HIGH: Replace 13-line Apache header and... (continued)

Coverage Stats

81 of 99 new or added lines in 11 files covered. (81.82%)

10 existing lines in 2 files now uncovered.

59392 of 89605 relevant lines covered (66.28%)

61.77 hits per line