ben-manes / caffeine / #5419

100%

push

github

Fix JCache close/createCache races and recursive teardown

CacheProxy.close() called cacheManager.destroyCache(name) before setting
closed=true, so the manager's recursive cache.close() executed full
teardown (shutdownExecutor, tryClose for each user resource,
invalidateAll) twice. Set closed=true first so the recursion
short-circuits, and tolerate destroyCache throwing on a closed manager
so an orphan cache can still release its own resources.

CacheManagerImpl.close() had the same recursion via cacheProvider.close,
causing the caches.values() iteration to run twice. Set closed=true
before the provider call and clear the caches map explicitly (since
each cache's destroyCache now no-ops when the manager is closed).

CacheManagerImpl.createCache/getCache only checked requireNotClosed
before mutating caches, so a creator could insert after close iterated
caches.values() and leave behind an orphan that survived manager
shutdown. Serialize both with close() on the same lock.

3929 of 3936 branches covered (99.82%)

37 of 37 new or added lines in 2 files covered. (100.0%)

8024 of 8024 relevant lines covered (100.0%)

1.0 hits per line