ben-manes / caffeine / #5413

100%

master: 100%

push

github

Fix removal in identity views and widen hill-climber counters

values().remove(o): for weak/soft value caches now uses identity
equivalence (matching IdentityHashMap's semantics) rather than Guava's
accidental equals-based behavior (inherited from AbstractCollection).

keySet()/entrySet().removeAll: the size optimization picks between
iterating the cache vs. iterating the user collection, but for weak
keys the cache compares by identity. Iterating the user collection
calls cache.remove(item) with a possibly equal-but-distinct instance,
which misses by identity. Always iterate the cache when collectKeys()
is true, matching IdentityHashMap.KeySet.removeAll's defensive comment.

hitsInSample and missesInSample widen from int to long to avoid
counters overflowing before the hill climber reset triggered, leaving
requestCount stuck negative and permanently disabling adjustment.

Expanded the internal consistency checks in the test assertions for a
more thorough verification.

3931 of 3936 branches covered (99.87%)

8 of 8 new or added lines in 3 files covered. (100.0%)

8020 of 8020 relevant lines covered (100.0%)

1.0 hits per line