KarpelesLab / libwallet / 24973542192

24%

Build Type

push

github

Committed by MagicalTux

Commit Message

wlttx: SignAndSend auto-validates so EVM fees / nonce / gas land

Sending ETH via Transaction:signAndSend without first calling
Transaction:validate failed with "invalid maxFeePerGas" — the
fee-population block lived only inside Validate, so a Dart caller
that built an UnsignedTransaction and shipped it straight to
signAndSend reached encodeTx with empty MaxFeePerGas / Nonce /
Gas. The existing comment at line 537-539 acknowledged the gap
("callers can reach signAndSend without going through validate
first") but only fixed the fee BACKFILL post-signing.

Now: SignAndSend auto-runs Validate as its first step. Validate's
field-population is idempotent (every write is gated on `if field
== ""` / `if field == 0`), so callers that already validated
incur no behaviour change — just one extra DB hit for the
acct/network resolution which is also done explicitly below.

Side benefit: erc20_transfer's To/Data rewrite (which only
happened inside Validate) now also fires on the signAndSend-only
path, fixing a latent bug where ERC-20 transfers built in Dart
without an explicit validate call would have signed with the
caller's recipient address as the `to` field instead of the
token contract.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Coverage Stats

0 of 3 new or added lines in 1 file covered. (0.0%)

108 existing lines in 1 file now uncovered.

2982 of 14828 relevant lines covered (20.11%)

128.16 hits per line