accordproject / concerto / 24967482949

98%

push

github

fix(concerto-cto): declare path-browserify as a runtime dependency (#1189)

`packages/concerto-cto/src/external.ts` has a top-level
`import * as pathBrowserify from 'path-browserify'` which is compiled
into the shipped `dist/` output, but the package declares
`path-browserify` under `devDependencies` instead of `dependencies`.

Consumers running `npm install @accordproject/concerto-cto` in a fresh
project get `MODULE_NOT_FOUND` at require time. The bug is invisible
inside the monorepo because npm workspaces hoist `path-browserify`
(declared in both the root and the package's devDependencies) to the
repo root, and the browser build is shielded by the `resolve.fallback`
shim in `webpack.config.js`.

This is a one-line move of `"path-browserify": "^1.0.1"` from
`devDependencies` to `dependencies`. `@types/path-browserify` stays in
devDependencies — type declarations are correctly dev-only.

No source or test changes required; behavior is unchanged for the
monorepo dev loop, fixed for downstream consumers.

Likely regression from #1005 (TypeScript migration).

Closes #1188

Signed-off-by: Yuzhou Wang <wusiwyzb5@gmail.com>

2035 of 2111 branches covered (96.4%)

Branch coverage included in aggregate %.

3808 of 3834 relevant lines covered (99.32%)

134951.22 hits per line