ben-manes / caffeine / #5410

100%

master: 100%

push

github

Fix value identity in values().remove; widen hill-climber counters

values().remove(o) for weak/soft value caches now uses identity
equivalence (matching IdentityHashMap's semantics) rather than Guava's
accidental equals-based behavior (inherited from AbstractCollection).

hitsInSample and missesInSample widen from int to long to avoid
counters overflowing before the hill climber reset triggered, leaving
requestCount stuck negative and permanently disabling adjustment.

Expanded the internal consistency checks in the test assertions for a
more thorough verification.

3923 of 3930 branches covered (99.82%)

3 of 3 new or added lines in 1 file covered. (100.0%)

8018 of 8018 relevant lines covered (100.0%)

1.0 hits per line