Chia-Network / chia-blockchain / 24957851778

91%

Build Type

push

github

Committed by web-flow

Commit Message

[CHIA-4180] Detect spend bundle rejections early in wallet test framework (#20768)

* Detect spend bundle rejections early in wallet test framework

The mempool-wait loop in wait_transaction_records_entered_mempool now
optionally checks the wallet's transaction store for non-recoverable
rejection errors and raises immediately instead of waiting for the full
timeout. process_pending_states error messages now include the original
exception for better CI diagnostics.

* Bump transaction rejection logs from INFO to WARNING

The ValueError and ValidationError rejection messages in
respond_transaction were logged at INFO level, which is below the
captured log threshold in tests. This made INVALID_SPEND_BUNDLE
rejections invisible in CI output — only the wallet-side warning
appeared, with no indication of the actual rejection reason (e.g.
"timeout 2.3 s", "too many pairs", validation error code).

Bumping to WARNING ensures the rejection reason appears in captured
test logs alongside the wallet rejection warning.

* Fix false-positive rejection detection for retried transactions

Address bugbot finding: sent_to accumulates both FAILED and SUCCESS
entries since increment_sent always appends. A transaction rejected by
one peer then accepted by another would trigger a spurious RuntimeError
on the stale FAILED entry.

Fix: (1) prune tx names from the rejection check set once their bundle
is found in the mempool, and (2) skip records that already report
is_in_mempool() (have a SUCCESS or PENDING entry), matching the
semantics of TransactionRecord.is_valid().

* Add tests for rejection detection and ValueError coverage paths

Cover the four lines flagged by diff-cover:
- full_node.py:2818 — ValueError handler in add_transaction
- full_node_simulator.py:536 — continue when wallet reports in_mempool
- full_node_simulator.py:538,543 — fast-fail RuntimeError on non-recoverable rejection

* Revert unrelated log level change per review feedback

Drop the info→warning bu... (continued)

Coverage Stats

10532 of 11725 branches covered (89.83%)

Branch coverage included in aggregate %.

87 of 87 new or added lines in 3 files covered. (100.0%)

12 existing lines in 4 files now uncovered.

107453 of 117576 relevant lines covered (91.39%)

1.83 hits per line