ReactiveX / RxPY / 24955540858

94%

Build Type

push

github

Committed by web-flow

Commit Message

test: fix pyright strict-mode errors in tests/test_observable (batch 2) (#782)

* test: fix pyright strict-mode errors in test_observable (batch 2)

Fix pyright strict-mode type errors in 30 files under tests/test_observable/,
continuing the incremental cleanup of the pyright exclusion list.

Error patterns fixed:
- _raise("string") → _raise(Exception("string"))
- def action(): → def action(_): for on_next callbacks (OnNext[T] requires a param)
- Notification union-attr access annotated with # type: ignore[union-attr]
- subscribe(scheduler="not_set") → subscribe(scheduler=None) for proper typing
- mapper/generate iterate lambdas annotated with # type: ignore[arg-type]
- do_action callback removing spurious return value
- factory(ex: Exception) → factory(ex: Exception | None) for on_error_resume_next
- return lambda: None → return None in subscribe functions
- Hoisted variables to avoid unbound-var errors inside assertRaises blocks
- Various other minor fixes (arg-type, call-arg, misc type: ignore)

260 tests pass. Part of ongoing effort to clean up pyright exclusions.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* refactor(tests): replace type:ignore comments with proper type annotations

Builds on PR #782 to replace the `# type: ignore` suppressions with
real type annotations and structural fixes:

- Use `isinstance(value, OnError|OnNext)` to narrow `Recorded.value` instead
  of `# type: ignore[union-attr]` (test_average, test_elementat, test_reduce,
  test_toiterable).
- Properly annotate test-local `subscribe` functions with
  `ObserverBase[T] / SchedulerBase | None / DisposableBase` and return
  `Disposable()` so `reactivex.create(...)` accepts them without
  `# type: ignore[misc]/[arg-type]` (test_concat, test_observeon, test_map,
  test_skipuntil, test_while_do).
- Type `xs` as `list[ColdObservable[int] | None]` in test_defer instead of
  bare `[None]`, and add `assert xs[0] is not None` narrowing.
- Annotate `_raise` a... (continued)

Coverage Stats

93 of 94 new or added lines in 25 files covered. (98.94%)

1 existing line in 1 file now uncovered.

25368 of 27126 relevant lines covered (93.52%)

0.94 hits per line