valkyrjaio / valkyrja-starter-app-php / 24948278064

0%

push

github

[Application] Update route handlers to accept RouteContract (#33)

# Description

Updates all route handler methods in both the HTTP and CLI route
providers to accept a typed `RouteContract` (or `DynamicRouteContract`)
parameter instead of an untyped `array $arguments`. Dynamic route
parameters are now retrieved via the route object's typed API
(`$route->getParameter('value')->getValue()`), and the redundant
`$container->getSingleton(RouteContract::class)` call in
`dynamicHandler` is removed in favour of the injected `$route` directly.

Bumps `valkyrja/sindri` from `^26.0.0` to `^26.1.0` to pull in the
updated handler contract.

---

## Types of Changes

- [x] Improvement _(non-breaking change which improves code)_
- [ ] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [ ] Breaking change _(fix or feature that would cause existing
functionality to change)_
- [ ] Documentation improvement

---

## Changes

- **`app/src/App/Cli/Provider/RouteProvider.php`** — added
`RouteContract $route` parameter to `testCommandHandler`; added
corresponding `use` import
- **`app/src/App/Http/Provider/RouteProvider.php`** — replaced `array
$arguments` with `RouteContract $route` on all handler methods; removed
now-unnecessary `@param` docblocks; updated `dynamicHandler` to fetch
the `value` parameter via `$route->getParameter('value')->getValue()`
and pass `$route` directly instead of resolving it from the container;
added `DynamicRouteContract` import
- **`composer.json`** — bumped `valkyrja/sindri` constraint from
`^26.0.0` to `^26.1.0`

0 of 10 new or added lines in 2 files covered. (0.0%)

0 of 288 relevant lines covered (0.0%)

0.0 hits per line