omry / omegaconf / 52895fa2-c777-439e-9783-c714d4152f6d

100%

master: 100%

push

circleci

Raise ConfigTypeError when updating through a null structured Optional node (closes #1214)

OmegaConf.update() would hit an AssertionError with a confusing message when
the key path traversed a structured Optional field set to None.

The root cause: DictConfig(content=None) is a Container, so the traversal
loop did not replace it with {}, then root[key] dereferenced to Python None,
and the post-loop assert fired with an unhelpful message.

The fix detects a null Container during traversal and raises ConfigTypeError
immediately, naming the offending intermediate key via _get_full_key:

    ConfigTypeError: Cannot set 'a.b' because 'a' is None

The post-loop assert is kept as an internal invariant guard with a simple
message. Untyped None values (AnyNode) are unaffected — they are replaced
with an empty dict as before.

Closes #1214.

3 of 3 new or added lines in 1 file covered. (100.0%)

3513 of 3513 relevant lines covered (100.0%)

1.0 hits per line