dineeek / ngx-libs-workspace / 24937838587

97%

push

github

feat(ngx-phone-form-field): quality-pass — fix active scroll, fix unparseable display, doc accuracy (#47)

* fix(ngx-phone-form-field): scroll the actual active option into view in the country picker

The picker's active-option scrolling used a singular viewChild bound to
a template ref (`#activeOption`) that was applied to every <li>.
Angular resolves singular viewChild queries to the FIRST match in
document order, so scrollIntoView always targeted the first option in
the list — the highlight could move past the visible area and the
popover never followed it.

Resolve the active option directly with `host.querySelector(
'.picker__option--active')` inside the same effect, and read
`activeIndex()` reactively so the scroll runs on keyboard nav (not
only on filter changes). Drop the now-unused template ref + viewChild.

* fix(ngx-phone-form-field): preserve a fallback display when external value is unparseable

`applyExternalValue` cleared the input whenever
`parsePhoneNumberFromString(v)` returned undefined and `format=true`,
leaving the model populated while the UI showed nothing — confusing
both the user and any consumer that round-trips form values through
the field.

Strip the leading dial code from the raw value as the last-resort
fallback for both `format=true` and `format=false`, so an unparseable
write like `+1abc` renders as `abc` in the national-number input.
The model is unchanged; this only affects what's painted.

* docs(ngx-phone-form-field): clarify emission contract, country codes, phoneCountryIn

Three documentation gaps Codex flagged on the v1.0.0 release:

- README claimed the emitted value is "always a valid E.164 string when
  set", but the component intentionally emits partial `+<dialcode><digits>`
  values during typing so consumers can react in real time. Replace the
  inaccurate paragraph with the full three-state contract (null / valid /
  in-progress) and a pointer to phoneValid() for strict validity.
- Add a "Country codes & ... (continued)

434 of 470 branches covered (92.34%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 2 files covered. (100.0%)

574 of 580 relevant lines covered (98.97%)

115.86 hits per line