dineeek / ngx-libs-workspace / 24937080436

97%

push

github

feat(ngx-numeric-range-form-field): quality-pass — fix ±Infinity, expose label/native/error-kind APIs, a11y wiring (#44)

* fix(ngx-numeric-range-form-field): treat ±Infinity input as null

`toNumberOrNull` only filtered NaN, but `Number('Infinity')` and
`Number('-Infinity')` return Infinity, which slipped through and was
emitted as a real range bound. Switch to `Number.isFinite` so the
helper rejects both NaN and ±Infinity uniformly.

* refactor(ngx-numeric-range-form-field): collapse bounds validator branches

Replace the four near-identical min/max blocks in numericRangeBounds
with a single per-side loop. Behaviour is unchanged — same error
kinds, same messages, same emission order — but the intent reads in
one place instead of being duplicated across both sides and both
bound directions.

* feat(ngx-numeric-range-form-field): expose minLabel, maxLabel and resetLabel inputs

The component baked "From" / "To" / "Reset range" into both the visible
placeholder and the accessible name, so localising the field meant
losing the visual hint or vice versa. Add three optional inputs that
default to the existing strings (minLabel/maxLabel fall back to the
placeholder) and let consumers override aria copy independently of
the visible placeholder.

No template changes for consumers who don't pass the new inputs.

* feat(ngx-numeric-range-form-field): expose native step / autocomplete / min / max / name attributes

The number inputs hard-coded native browser affordances, so consumers
who needed `step="0.5"`, `autocomplete="off"`, named form fields, or
side-specific HTML `min`/`max` clamps had to wrap the component or
override attributes from outside.

Add optional inputs that forward to the underlying inputs:
- `step`, `autocomplete` (shared by both sides)
- `minName`, `maxName` for per-side `name` attributes
- `minMin` / `minMax` / `maxMin` / `maxMax` for per-side native HTML
  range hints — schema validation remains the source of truth, these
  only steer the... (continued)

439 of 475 branches covered (92.42%)

Branch coverage included in aggregate %.

34 of 34 new or added lines in 3 files covered. (100.0%)

573 of 579 relevant lines covered (98.96%)

113.89 hits per line