valkyrjaio / valkyrja-php / 24926358529

100%

push

github

[Http] Remove route arguments map in favor of ParameterContract values (#781)

## Description

Removes the flat `arguments` map from `RouteContract` and `Route`, which
was a duplicate of values already stored on each `ParameterContract`.
Introduces `getParameter()` and `hasParameter()` on
`DynamicRouteContract` so callers can look up parameter values by name
without an intermediate array. Updates the Http route handler callable
signature to receive the matched `RouteContract` directly instead of an
extracted arguments array.

Also fixes a latent bug in `EntityRouteMatchedMiddleware` where the flat
`$arguments` array and the `ParameterContract` objects could become
misaligned when entity parameters were resolved.

---

## Types of Changes

- [ ] Improvement _(non-breaking change which improves code)_
- [x] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [x] Breaking change _(fix or feature that would cause existing
functionality to change)_
- [ ] Documentation improvement

---

## Changes

- **`src/Valkyrja/Http/Routing/Data/Contract/RouteContract.php`** —
removed `getArguments()`, `withArguments()`; updated handler callable
type from `callable(ContainerContract, array<string, mixed>):
ResponseContract` to `callable(ContainerContract, RouteContract):
ResponseContract`
- **`src/Valkyrja/Http/Routing/Data/Contract/DynamicRouteContract.php`**
— added `getParameter(string $name): ParameterContract` and
`hasParameter(string $name): bool`
- **`src/Valkyrja/Http/Routing/Data/Route.php`** — removed `$arguments`
field, `getArguments()`, `withArguments()`; updated handler type
annotations
- **`src/Valkyrja/Http/Routing/Data/DynamicRoute.php`** — added
`getParameter()` and `hasParameter()` implementations; updated handler
type annotation
- **`src/Valkyrja/Http/Routing/Matcher/Matcher.php`** — simplified
`processArguments()` t... (continued)

25 of 25 new or added lines in 6 files covered. (100.0%)

12467 of 12493 relevant lines covered (99.79%)

15.83 hits per line