valkyrjaio / sindri-php / 24917140390
100%

DEFAULT BRANCH: 26.x
Ran
Jobs 1
Files 79
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 100.0%. Remained the same
24917140390

push

github

web-flow 
[Tests] Use phpunit package's ServiceProviderTestCase in service provider tests (#30)

# Description

Replaces the hand-rolled service provider test classes with the
`ServiceProviderTestCase` base from `valkyrja/phpunit`, aligning Sindri
with the same pattern used across the Valkyrja monorepo.

Both `SindriAstServiceProviderTest` and
`SindriCommandServiceProviderTest` previously extended `TestCase`
directly and used mock containers with per-method assertions. They now
extend `ServiceProviderTestCase`, use the real `Container`, and follow
the standard `testExpectedPublishers` / `testPublish*` structure.

`valkyrja/phpunit` was also updated from `v26.1.0` to `v26.3.0` (which
is where `ServiceProviderTestCase` was introduced), along with the
associated `phpunit` and `php-code-coverage` upgrades that came with it.

---

## Types of Changes

- [x] Improvement _(non-breaking change which improves code)_
- [ ] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [ ] Breaking change _(fix or feature that would cause existing
functionality to change)_
- [ ] Documentation improvement

---

## Changes

- **`tests/Tests/Unit/Provider/SindriAstServiceProviderTest.php`** —
rewritten to extend `ServiceProviderTestCase`; replaced mock-based
individual publisher tests with real-container `testPublish*` methods
and a consolidated `testExpectedPublishers`
- **`tests/Tests/Unit/Provider/SindriCommandServiceProviderTest.php`** —
same approach; single `testPublishGenerateDataFromConfigCommand` using
real container with all required singletons pre-set
- **`.github/ci/phpunit/composer.lock`** — updated `valkyrja/phpunit`
from `v26.1.0` → `v26.3.0`, `phpunit/phpunit` from `13.0.6` → `13.1.7`,
`phpunit/php-code-coverage` from `13.0.2` → `14.1.6`, `phpunit/phpcov`
from `12.0.0` → `13.0.1`

1523 of 1523 relevant lines covered (100.0%)

16.31 hits per line

Jobs
ID Job ID Ran Files Coverage
1 24917140390.1 79
100.0
 GitHub Action Run
Source Files on build 24917140390