ForumMagnum / ForumMagnum / 24916627575

46%

master: 47%

Build Type

push

github

Committed by claude

Commit Message

Filter rejected posts from server-side query helpers

In preparation for enabling the rejection feature on EA Forum, plug three
places where rejected posts could leak through despite the default Posts
view's rejection filter:

- getViewablePostsSelector: add "rejected" IS NOT TRUE to the SQL helper.
  This selector is used in 18+ queries (sitemap, embeddings, sequences,
  collections, recommendations, user profiles, etc.) that bypass the
  default view, so the omission was a real leak. The header comment on
  the helper already says it must mirror the default view, which has
  filtered rejected since the field was added.

- userPosts view: drop the "rejected: null" override so user profile
  post lists inherit the default view's rejection filter. Previously,
  any visitor to a user's profile would see that user's rejected posts
  mixed into the public list. Authors who want to audit their rejected
  content can use /moderation. The sunshineNewUsersPosts view still
  explicitly opts in via its own "rejected: null", which is correct
  for the moderator review surface.

- PostsRepo.getSearchDocuments / countSearchDocuments: skip rejected
  posts during bulk Elasticsearch reindex. Search queries already
  filter rejected at query time via ElasticConfig, but defense in
  depth is cheap here and avoids inflating reindex counts.

Coverage Stats

7918 of 10713 branches covered (73.91%)

Branch coverage included in aggregate %.

0 of 3 new or added lines in 2 files covered. (0.0%)

7 existing lines in 2 files now uncovered.

177770 of 373098 relevant lines covered (47.65%)

36.54 hits per line