dangernoodle-io / breadboard / 24907700113

100%

push

github

fix(mdns): cap base name length so instance-name snprintf can't truncate (#79)

ci's esp toolchain enforces -werror=format-truncation and flagged the
mac-suffix concat as a potential overflow: if the caller's base name
is 63 chars and out_size is 64, the trailing '-xxxx\0' runs off the
end. gcc proves the overflow and errors.

use %.*s with a base-length cap of (out_size - 6) — 6 = strlen("-xxxx")
plus null terminator. suffix always fits, compiler verifies.

81 of 81 branches covered (100.0%)

Branch coverage included in aggregate %.

113 of 113 relevant lines covered (100.0%)

274.59 hits per line