valkyrjaio / valkyrja-php / 24905429542

100%

push

github

[Remove] Data file generators for container, cli, event, and http (#777)

# Description

Removes all `DataFileGenerator` classes across the `Container`,
`Cli/Routing`, `Http/Routing`, and `Event` packages, along with the CLI
`data:generate` and `http:data:generate` commands that depended on them.
The `Support/Generator` base classes (`FileGenerator`,
`FileGeneratorContract`, `GenerateStatus`) are retained as they are
still used by `CacheResponseMiddleware` via `ResponseFileGenerator`.

---

## Types of Changes

- [ ] Improvement _(non-breaking change which improves code)_
- [ ] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [x] Breaking change _(fix or feature that would cause existing
functionality to change)_
- [ ] Documentation improvement

---

## Changes

### Removed

- `Container\Generator\DataFileGenerator` and related classes/contracts
- `Cli\Routing\Generator\DataFileGenerator` and related
classes/contracts
- `Http\Routing\Generator\DataFileGenerator` and related
classes/contracts
- `Event\Generator\DataFileGenerator` and related classes/contracts
- `Cli\Server\Command\GenerateDataCommand` (`data:generate` CLI command)
- `Http\Routing\Cli\Command\GenerateDataCommand` (`http:data:generate`
CLI command)
- `Application\Cli\Command\Abstract\GenerateData` base command
- Unit tests for all of the above

### Modified

- **`CliConfig` / `CliConfigContract`** — removed the embedded `$http`
property (carried over from an era when CLI apps needed HTTP config for
generation)
- **`App::bootstrapServices`** — removed the `HttpConfigContract`
singleton registration in the CLI boot path
- **Service providers** (`Container`, `CliRouting`, `HttpRouting`,
`Event`, `CliServer`, `HttpRoutingCli`) — removed
`publishDataFileGenerator` / `publishGenerateDataCommand` deferred
publishers and route registrations
- **`Cli/README.md... (continued)

14 of 14 new or added lines in 4 files covered. (100.0%)

12465 of 12465 relevant lines covered (100.0%)

16.18 hits per line