healthchecks / healthchecks / 24891570575

91%

push

github

Fix email integration to handle deep attachment stacks in last ping body

The email integration includes last ping body in the email alerts.
If the last ping was a HTTP ping, the last ping body goes
in the text/html part of the message.
If the last ping was an email ping, the last ping body is attached
as an .eml attachment. This way, the email clients can display
the last ping body as a formatted email message.

Things can go wrong if the last ping body is an email message
which itself has an attachment, which is an email message, which
itself has an attachment, which is and em.....

If the attachment-in-attachment stack is deep enough (~120 messages)
then our code will throw a max recursion error when sending the
email alert. IIUC the email parsing machinery needs to walk all
message parts to make sure there are no boundary string conflicts.
Or something like that. And it does it recursively.

The fix I chose was to drop message/rfc822 attachments from the
last ping body. The user can still download the full last ping
body, recursive attachments and all, from the web UI.

2 of 4 new or added lines in 1 file covered. (50.0%)

8290 of 9074 relevant lines covered (91.36%)

0.91 hits per line