safe-global / safe-client-gateway / 24890845979

90%

push

github

feat: share counterfactual safes across users via junction table (#3055)

* feat: share counterfactual safes across users via junction table

Before, each row in `counterfactual_safes` was owned by a single creator
and the POST endpoint rejected any subsequent attempt to register the
same (chainId, address) pair with a 409, even if the submitted init
params matched exactly. This blocked a common real-world scenario where
two space members independently add the same counterfactual safe to
separate spaces (for example, after one member copies the safe from
another space and then adds a new chain that the original member later
tries to add too).

- Add a `counterfactual_safe_users` junction table keyed on
  `(counterfactual_safe_id, user_id)`, backfilled from the existing
  `creator_id`. `creator_id` is retained as first-creator audit metadata.
- Make the create path idempotent: when a row exists for (chainId,
  address) and every init param matches exactly, insert only the
  association for the caller; when init params differ, raise 409.
- Rename `findByCreatorId` to `findByUserId` and query through the
  junction so callers see every safe they are associated with, not only
  ones they authored.
- Delete now removes only the caller's association and keeps the
  canonical row (preserving the association graph for other users and
  spaces).

The 22 repository integration tests cover the new idempotent-match,
params-mismatch-409, second-user-attach, and delete-only-unlinks paths
against a real Postgres.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* chore: prettier

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* refactor: address review feedback on counterfactual-safes create

- Race safety: replace the find→insert sequence with a single bulk
  INSERT ... ON CONFLICT DO NOTHING, then SELECT back the authoritative
  canonical rows. Under concurrent POSTs for the same (chainId, address)
  one transaction win... (continued)

3309 of 4117 branches covered (80.37%)

Branch coverage included in aggregate %.

54 of 57 new or added lines in 4 files covered. (94.74%)

15658 of 16965 relevant lines covered (92.3%)

559.58 hits per line