stacklok / toolhive / 24886077856

67%

Build Type

push

github

Committed by web-flow

Commit Message

llm: extract shared OIDC config, move business logic to pkg/llm, add E2E tests (#5049)

* llm: extract shared OIDC config, move business logic to pkg/llm, add E2E tests

Three follow-up cleanups from the #5029 review (#5048):

1. Extract shared OIDC config type into pkg/oidc.ClientConfig. Both
   config.RegistryOAuthConfig and llm.OIDCConfig are now type aliases for
   this type, so field additions and validation changes apply to both
   authentication flows without drift.

2. Move business logic from the CLI layer into pkg/llm per the cli-commands
   convention. The config-set mutation/validation branch, the config-show
   text formatter, and the cached-token deletion logic all live in pkg/llm
   now. The CLI commands are thin wrappers that parse flags and delegate.

3. Add E2E tests for thv llm config set/show/reset, covering happy-path
   round-trips, HTTPS enforcement, incremental configuration, the
   not-configured message, and post-reset state.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* llm: fix errcheck lint failures in Show method

Show now returns an error and uses a writef closure to propagate the
first write failure rather than ignoring io.Writer errors. The CLI
caller is updated to return the error directly.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* llm: skip token deletion for providers that can't list or delete

Providers like the environment provider are read-only and cannot hold
cached tokens, so calling ListSecrets on them would always produce a
spurious warning during thv llm config reset. Check CanList/CanDelete
capabilities first and treat non-capable providers as a no-op.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* llm: add unit tests for SetFields, DeleteCachedTokens, and Show

Covers the business logic introduced in manage.go:
- SetFields: field mutation, partial vs full validation branching,
  invalid-value rejection
- DeleteCachedTokens: capability no-ops (no CanList/Ca... (continued)

Coverage Stats

70 of 83 new or added lines in 3 files covered. (84.34%)

35 existing lines in 4 files now uncovered.

59167 of 89337 relevant lines covered (66.23%)

60.03 hits per line