umputun / revdiff / 24880690188

90%

push

github

fix(themes): persist theme into Application Options section (#149)

* fix(themes): persist theme into Application Options section

patchConfigTheme appended `theme = ...` at EOF when no existing theme line
was found. If the config ended with `[color options]` (or any non-default
section), the new line landed inside that section and go-flags reported
`unknown option: theme` on next startup, discarding the setting. Now the
insert skips past any [Application Options] headers and places the entry
just before the first non-default section header (or at EOF if none).

Also promoted patchConfigTheme to a method on *themeCatalog since it was
called only from themeCatalog.Persist.

Related to #148

* style: gofmt column alignment in two test files

* fix(themes): heal misplaced theme line and round-trip tests

Code-review followup to the #148 fix.

The replace-in-place branch of patchConfigTheme was matching the first
`theme = ...` line anywhere in the file and rewriting it at the same
location. If a user's config was already corrupted by the pre-fix persist
path (theme line stuck inside `[color options]`), the new binary kept
rewriting at the wrong location and go-flags still reported
`unknown option: theme` on next startup.

Make the scan section-aware: track the active INI section while walking
lines; replace in place only when the found line lives in the default
scope ([Application Options] or the unnamed top-of-file section);
otherwise delete the stray line and run the insertion path so the new
entry lands before the first non-[Application Options] header.

Also split the scan and insertion-position logic into two helper methods
on *themeCatalog to keep cyclomatic complexity within the linter limit.

Add an end-to-end regression test that round-trips patched files through
flags.NewIniParser and asserts opts.Theme resolves without error,
covering three testdata fixtures (good / no-theme-yet / corrupted). This
is the assertion that would have caught #148 or... (continued)

48 of 52 new or added lines in 1 file covered. (92.31%)

8441 of 9437 relevant lines covered (89.45%)

551.27 hits per line