umputun / revdiff / 24880590308

89%

master: 90%

Pull #149

github

fix(themes): remove all misplaced theme lines during heal

Addresses Copilot review finding on #149. The previous heal logic found
the first `theme = ...` occurrence and stopped. When a user hand-repaired
a config corrupted by the pre-fix bug by adding a valid `theme = ...`
in [Application Options] without deleting the stray inside
[color options], the patch updated the valid line in place and left
the stray, so go-flags kept erroring with `unknown option: theme` on
next startup.

scanThemeLine -> scanThemeLines now walks the full file and reports
the first default-scope index separately from every stray. The patch
loop deletes strays in reverse order (to keep earlier indices stable)
before replacing/inserting the canonical entry.

Add TestPatchConfigTheme_removesStrayDuplicates regression test and
extend the testdata round-trip table with duplicate.ini, a fixture
shaped like the hand-repair scenario, to assert the file parses cleanly
via flags.NewIniParser after the heal.

Related to #148

48 of 52 new or added lines in 1 file covered. (92.31%)

8441 of 9437 relevant lines covered (89.45%)

551.27 hits per line