kubeovn / kube-ovn / 24877779623
25%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 207
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 24.856% (+0.003%) from 24.853%
24877779623

push

github

web-flow 
test(iptables-vpc-nat-gw): gate custom namespace assertions on v1.17+ (#6676)

* test(iptables-vpc-nat-gw): gate custom namespace assertions on v1.17+

The "[1] change gateway image, custom annotations and custom namespace"
spec was guarded with SkipVersionPriorTo(1, 16, ...), but the
VpcNatGateway/IptablesEIP spec.namespace plumbing was introduced after
release-1.16 branched. On release-1.16 builds the gate did not trip
(version is not prior to 1.16), apiserver silently dropped the unknown
spec.namespace field, the controller created the pod in PodNamespace,
and the assertion looking in customNs failed deterministically.

Move the namespace-related setup, the IptablesEIP spec.namespace test
and the auto-backfill test behind VersionPriorTo(1, 17). On older
builds customNs is empty, framework falls back to NamespaceSystem, and
only the image/annotations behavior (which is supported on 1.16) is
exercised.

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>

* test(iptables-vpc-nat-gw): use framework.KubeOvnNamespace for default pod ns

Address Copilot review feedback on #6676: framework.KubeOvnNamespace is
the codebase's idiomatic way to refer to the controller install
namespace. Although it currently aliases metav1.NamespaceSystem, using
the framework constant keeps the assertion correct if the install
namespace ever moves.

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>

---------

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>

14069 of 56601 relevant lines covered (24.86%)

0.29 hits per line

Jobs
ID Job ID Ran Files Coverage
1 24877779623.1 207
24.86
 GitHub Action Run
Source Files on build 24877779623