KarpelesLab / libwallet / 24876427590

25%

Build Type

push

github

Committed by MagicalTux

Commit Message

web3: implement personal_ecRecover locally

EIP-1474's personal_ecRecover is a wallet-side operation (recover
signer address from message + signature), not a chain operation.
Most public Ethereum nodes return -32601 for it, so the previous
default-relay path failed every dApp that called it for signature
verification (SIWE, Snapshot, login flows, etc.).

EthPersonalEcRecover lives in wltacct alongside SignEthereumDigest
and is the inverse of personal_sign: applies the EIP-191 prefix,
runs ECDSA recovery, returns the EIP-55 address. Accepts both
{27, 28} (legacy) and {0, 1} (raw) v bytes — same tolerance
MetaMask, ethers, and viem apply.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Coverage Stats

28 of 66 new or added lines in 2 files covered. (42.42%)

40 existing lines in 1 file now uncovered.

2776 of 14144 relevant lines covered (19.63%)

56.06 hits per line