babelfish-for-postgresql / babelfish_extensions / 24873678572

77%

push

github

Fix missing xmlns:xsi namespace on elements when using FOR XML RAW('') with ELEMENTS XSINIL (#4764)

Currently, when using FOR XML RAW('') , ELEMENTS XSINIL (empty element name), Babelfish omits the xmlns:xsi namespace declaration from the output elements. T-SQL places xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" on every element when there is no row wrapper element, since there is no parent element to inherit the namespace from.

For example, SELECT 1 AS a, NULL AS b FOR XML RAW(''), ELEMENTS XSINIL produces:

Babelfish (before): <a>1</a><b xsi:nil="true"/>

T-SQL: <a xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">1</a> <b xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:nil="true"/>

With this change, Babelfish now adds the xmlns:xsi namespace declaration to each element when RAW('') is used with ELEMENTS XSINIL, matching T-SQL behavior. This applies to both non-null elements and nil elements.

Task: BABEL-6445
Signed-off-by: Japleen Kaur <amjj@amazon.com>

Signed-off-by: Japleen Kaur <amjj@amazon.com>

6 of 6 new or added lines in 1 file covered. (100.0%)

53375 of 69174 relevant lines covered (77.16%)

623190.02 hits per line