qiita-spots / qiita / 24854619598

92%

master: %

push

github

fix #3515: run register_commands off the ioloop (#3516)

ReloadPluginAPItestHandler.post() was calling register_commands()
synchronously, which shells out via Popen.communicate() and blocks the
master Tornado ioloop for the duration of the plugin register
subprocess. That subprocess calls back into qiita through nginx; nginx
round-robins across master and workers, so roughly one in four callback
POSTs land on the blocked master and time out (504), breaking CI for
plugins that register more than one command (e.g. qtp-biom).

Move the blocking call off the ioloop via IOLoop.run_in_executor so
master can continue serving /activate/ callbacks while register_commands
runs in the default thread pool. _system_call and register_commands are
unchanged; all their other callers run outside handler context already.

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

4 of 5 new or added lines in 1 file covered. (80.0%)

25449 of 27661 relevant lines covered (92.0%)

0.92 hits per line