OSSystems / compress-tools-rs / 24838251277

78%

master: 78%

Build Type

Pull #163

github

Committed by otavio

Commit Message

fix!: reject mtree specifications on archive entry points

libarchive's mtree format handler matches arbitrary free-form text, so inputs as innocuous
as a plain gunzip'd text file were being parsed as single-entry mtree "archives". This
defeats the guarantee added alongside the raw-handler removal, where archive entry points
are supposed to reliably reject non-archive bytes.

- After each successful archive_read_next_header, check archive_format and treat an mtree
  match the same way we treat the raw handler: return an Extraction error instead of
  yielding bogus entries
- Wire the check into list_archive_files, list_archive_entries, uncompress_archive,
  uncompress_archive_file, and ArchiveIterator (covering their _with_encoding and async
  siblings via the shared helpers)
- Expose archive_format plus ARCHIVE_FORMAT_BASE_MASK / ARCHIVE_FORMAT_MTREE through the
  FFI bindings and generate-ffi script
- Extend CHANGES.md and the crate-level docs to describe the mtree rejection alongside the
  existing raw-handler note
- Add regression tests that feed tests/fixtures/file.txt.gz through list_archive_files and
  ArchiveIterator to confirm both surfaces reject the mtree interpretation

Pull Request Pull Request #163: Reject non-archive inputs on archive entry points (#77)

Coverage Stats

85 of 88 new or added lines in 3 files covered. (96.59%)

1 existing line in 1 file now uncovered.

2003 of 2551 relevant lines covered (78.52%)

94.72 hits per line