safe-global / safe-events-service / 24831904352

87%

Build Type

push

github

Committed by web-flow

Commit Message

feat: migrate webhook HTTP client from axios to undici with retry (#492)

Closes [PLA-1252](https://linear.app/safe-global/issue/PLA-1252/optimize-webhook-http-delivery)
Closes #116

## Summary

- Replace `@nestjs/axios` / `HttpService` with a `RetryAgent(new Agent(...))` provider injected under `UNDICI_AGENT` in `WebhookModule`
- Rewrite `postWebhook` as plain `async/await`, removing the RxJS `firstValueFrom` / `catchError` / `of` layer
- Add exponential-backoff retry on transient network errors and 5xx responses (`maxRetries: 2`, `minTimeout: 200ms`, `timeoutFactor: 2`)
- Add `X-Delivery-Id` header (stable UUID across retries) for idempotent processing on the receiver side
- Increase default `HTTP_TIMEOUT` from 1s → 5s; `connectTimeout` now also bounded by `HTTP_TIMEOUT`
- Add `HTTP_MAX_RETRIES` env var; remove `@nestjs/axios` and `axios` dependencies

## Notes

- `methods: ['POST']` is set explicitly — POST is not in undici's default retry method list, so omitting it would silently disable all retries
- Retry on 5xx implies potential duplicate delivery; use `X-Delivery-Id` to deduplicate on the receiver side
- Response body is always consumed (`body.text()`) as required by undici v8

Coverage Stats

235 of 272 branches covered (86.4%)

Branch coverage included in aggregate %.

42 of 42 new or added lines in 3 files covered. (100.0%)

3 existing lines in 1 file now uncovered.

610 of 704 relevant lines covered (86.65%)

16.84 hits per line