gefyrahq / gefyra / 24822394246

78%

push

github

feat(GO-1026): allow passing arbitrary container engine args to gefyra run (#913)

* feat: allow passing arbitrary container engine args to gefyra run

Use Click's unknown-options forwarding so that any docker/podman
parameter (e.g. --cpu-shares, --mem-reservation, --cpu-period) can be
passed through to the container engine via `gefyra run ... -- --arg val`.

Deprecate the existing --cpu and --memory flags in favour of the generic
passthrough. A warning is emitted when Gefyra-managed keys (network,
dns, pid_mode) are overridden via extra args

* fix(GO-1026): raise UsageError for managed-key conflicts in extra container args

* fix(#GO-1026): correct --cpu/--memory deprecation hints in gefyra run

  The previous hints pointed to --cpu-quota and --mem-limit as 1:1
  replacements, but k8s-style values (500m, 512Mi) aren't accepted
  by the container engine. Clarify the passthrough equivalent with
  concrete examples and format notes.

  Addresses review feedback on #913

515 of 838 branches covered (61.46%)

Branch coverage included in aggregate %.

4919 of 6130 relevant lines covered (80.24%)

1.04 hits per line