stacklok / toolhive / 24803393891

67%

Build Type

push

github

Committed by web-flow

Commit Message

Honor --debug flag in vmcp (#5008)

vmcp's main.go called viper.GetBool("debug") before cobra parsed CLI
flags, so the --debug flag was effectively a no-op — the logger was
always initialized at INFO regardless of the flag. This also meant
slog.Debug calls in dependent packages (e.g. Cedar's
"Resolved JWT claim keys for Cedar evaluation" log at
pkg/authz/authorizers/cedar/core.go:452) were never visible even with
--debug on the command line.

Move logger initialization into the root command's PersistentPreRunE so
it runs after cobra has parsed flags and viper has the parsed value.
Leave a minimal INFO-level default logger installed in main() so any
error emitted before cobra's Execute runs still produces structured
output. Matches the pattern already used in cmd/thv/app/commands.go.

Coverage Stats

0 of 15 new or added lines in 2 files covered. (0.0%)

14 existing lines in 3 files now uncovered.

58644 of 88529 relevant lines covered (66.24%)

63.09 hits per line