decentraland / squid-management-server / 24802458721

54%

main: 48%

Build Type

Pull #75

github

Committed by LautaroPetaccio

Commit Message

test: cover invalid-name, DROP failure, credits DB, and guard throws

Close the test coverage gaps flagged in review. All four cases now
have their own 'when/and' describe blocks following the project's
dcl-testing conventions.

- olderThanMs <= 0: asserts the guard throws before any ECS or
  database call.
- invalid-name: an 'squid_old-with-hyphen' fixture exercises the
  SAFE_SCHEMA_NAME defensive gate. Asserts the schema is reported
  under skipped with reason 'invalid-name' and no transaction opens.
- DROP failure: dappsMock.withTransaction.mockImplementationOnce
  throws for the one candidate. Asserts the failure is not listed
  under deleted, the transaction was attempted, and the skip
  reasons for the other candidates are still surfaced — which is
  the "one broken DROP doesn't abort the run" contract the per-
  schema try/catch added earlier.
- Credits DB: populates creditsMock with its own orphan schema,
  asserts result.deleted contains a `database: 'credits'` entry
  and the transaction opens on creditsMock, not dappsMock.

One additional small assertion in the existing dry-run case that
result.dryRun is `true` — the field is new and now covered.

Tests grow from 40 to 50 passing.

Pull Request Pull Request #75: Purge old, unused squid schemas on a daily schedule

Coverage Stats

80 of 168 branches covered (47.62%)

Branch coverage included in aggregate %.

86 of 105 new or added lines in 3 files covered. (81.9%)

1 existing line in 1 file now uncovered.

237 of 422 relevant lines covered (56.16%)

7.32 hits per line