mindersec / minder / 24798705414

60%

Build Type

push

github

Committed by web-flow

Commit Message

Decouple PR feedback actions from GitHub-specific provider (#6262)

* feat: decouple PR feedback actions from GitHub-specific provider

Add generic CommitStatusPublisher and ReviewPublisher interfaces to
pkg/providers/v1 so that commit_status alert and pull_request_comment
alert/remediate actions are no longer hardcoded to provinfv1.GitHub.

Previously both actions fell back silently to NoopAlert/NoopRemediate
with a misleading log message when used with any non-GitHub provider.
This change replaces the GitHub-specific type assertions with generic
interface casts, improving extensibility for future VCS providers.

Changes:
- Define CommitStatus and Review DTOs in pkg/providers/v1
- Define CommitStatusPublisher and ReviewPublisher interfaces
- Implement PublishCommitStatus, PublishReview, DismissPublishedReview
  on the GitHub client as adapter methods
- Add compile-time interface assertions on the GitHub client struct
- Refactor commit_status action to cast to CommitStatusPublisher
- Refactor pull_request_comment action to cast to ReviewPublisher
- Update alert.go and remediate.go to use the new generic interfaces
- Regenerate mocks and update unit tests to MockCommitStatusPublisher
  and MockReviewPublisher

* security: upgrade vulnerable dependencies

* feat(pr-feedback): implement advanced PR review life cycle

Narrow the scope of PR feedback to pull request comments by removing
commit statuses. Refactor provider interfaces to use standard GitHub
methods and implement create-or-update/dismiss logic for Minder reviews.

Co-Authored-By: Antigravity <noreply@google.com>

* fix: stabilize CI, resolve proto breaking changes and regenerate mocks

* fix: restore binary compatibility in proto, sync generation and tidy deps

* fix: synchronize all provider mocks after interface refactoring

* fix: regenerate all proto, mock, and swagger files with proper toolchain

Ran 'make bootstrap' to install buf, sqlc, mockgen, then 'make gen'
to regenerate all files f... (continued)

Coverage Stats

61 of 83 new or added lines in 4 files covered. (73.49%)

7 existing lines in 2 files now uncovered.

20287 of 33623 relevant lines covered (60.34%)

35.98 hits per line