decentraland / squid-management-server / 24798481661

54%

main: 48%

Build Type

Pull #75

github

Committed by LautaroPetaccio

Commit Message

refactor: extract purge queries to queries.ts and reuse existing ones

The queries used by purgeOldSchemas were inlined in component.ts; move
them next to the other SQL builders and, while doing so, drop a
duplicate of the already-existing getSchemaByServiceNameQuery.

New exports in src/ports/squids/queries.ts:
- getSquidSchemasQuery() — enumerates schema_name LIKE 'squid_%'.
- getSchemaAgesQuery(schemas) — MAX(indexers.created_at) per schema.
- getActivelyPromotedSchemasQuery() — the currently promoted set.
- buildDropSchemaStatement(schema) — returns the plain-string
  `DROP SCHEMA <name> CASCADE` with identifier escaping, because
  the name is an identifier and not a parameterisable value.
- getDeleteIndexersBySchemaQuery(schema) — removes the indexers
  rows that reference a dropped schema.

The running-service lookup now reuses getSchemaByServiceNameQuery
instead of re-writing the same statement inline.

Testing fallout:
- jest.mock('../../src/ports/squids/queries') was auto-mocking every
  export, so my SQL-text-based router in the purge tests was seeing
  undefined statements. Replaced the bare jest.mock with a factory
  that keeps the real implementations and only stubs getPromoteQuery
  (the promote test's existing stub).
- The router's "latest schema per service" branch was also matching
  against "FROM public.indexers WHERE service" as a contiguous
  substring; the real getSchemaByServiceNameQuery splits that across
  a newline. Loosened the check to `public.indexers` + `WHERE service`.
- ECS mocks for the happy-path purge test switched from
  `mockImplementation` with `instanceof` checks to
  `mockResolvedValueOnce` chains (jest auto-mocked classes don't
  preserve instanceof reliably, so the instanceof branches were
  silently falling through).

Pull Request Pull Request #75: Purge old, unused squid schemas on a daily schedule

Coverage Stats

72 of 160 branches covered (45.0%)

Branch coverage included in aggregate %.

66 of 86 new or added lines in 3 files covered. (76.74%)

1 existing line in 1 file now uncovered.

217 of 403 relevant lines covered (53.85%)

5.07 hits per line