decentraland / squid-management-server / 24796790408

54%

main: 48%

Build Type

Pull #75

github

Committed by LautaroPetaccio

Commit Message

test: restructure specs per dcl-testing standards

Reorganize both unit test files to match the project's testing
conventions: describe blocks use "when" for scenarios and "and" for
nested branches, each it() asserts one behavior with a specific
description, input data and mocks are arranged in beforeEach rather
than inside it(), and jest.clearAllMocks() runs in afterEach.

squid-controller.spec.ts
- Each method describe (list/promote/downgrade/purgeOldSchemas) now
  nests "when <scenario>" blocks even for single-case methods, so
  future cases have an obvious home.
- Add the afterEach jest.clearAllMocks() that was missing.
- Move component construction and the call under test out of every
  it() and into the scenario's beforeEach, storing the result in a
  typed `let` for assertions.
- Split the old happy-path purge test into one it() per asserted
  behavior (deletion count/shape, skip reasons, transaction shape,
  per-statement ordering). The dry-run branch becomes its own
  "and dryRun is true" sibling so the non-dry-run beforeEach doesn't
  execute the real DROP twice.

squid-monitor.spec.ts
- Inline the previously-global mockSquids fixture per-scenario, so
  each describe constructs the exact squid shape it needs. The
  prior setup leaked four squid shapes across four unrelated cases.
- Hoist fiveMinutesAgo / noMetricsFirstDetected.set() / recovered
  squid definitions out of it() blocks and into their enclosing
  beforeEach, so each it() does nothing but assert.
- Split the "no metrics" describe into "and it is the first
  detection", "and more than 5 minutes have passed", and "and an
  alert was just sent in the previous tick" nested blocks. The
  recovery scenario moves to its own top-level "when a previously-
  alerting squid reports metrics again" describe.
- Each multi-assertion test becomes several single-assertion its.

Tests grow from 14 to 40 passing; coverage is unchanged.

Pull Request Pull Request #75: Purge old, unused squid schemas on a daily schedule

Coverage Stats

72 of 160 branches covered (45.0%)

Branch coverage included in aggregate %.

62 of 82 new or added lines in 2 files covered. (75.61%)

1 existing line in 1 file now uncovered.

209 of 399 relevant lines covered (52.38%)

4.96 hits per line