Alan-Jowett / sonde / 24787419019

82%

Build Type

push

github

Committed by web-flow

Commit Message

feat(modem): emit BUTTONSHORT and BUTTONLONG events (GPIO active-low on 1-Wire line) (#782)

* feat(modem): emit BUTTONSHORT and BUTTONLONG events via GPIO polling

Add button press detection on the 1-Wire data line (GPIO2 / XIAO D1)
to the modem firmware. The modem debounces input (30 ms), classifies
presses as BUTTON_SHORT (< 1 s) or BUTTON_LONG (≥ 1 s) on release,
and emits \EVENT_BUTTON\ (type \

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* style: run cargo fmt

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* refactor(modem): inject deterministic clock into ButtonScanner, fix review comments

Address PR #782 review feedback:

- Inject deterministic time via \poll_at(now, pressed)\ method on
  \ButtonScanner\, eliminating \	hread::sleep()\ from 7 of 8 tests.
  Tests now run in ~0.27s (was ~2.2s) and are immune to CI timing jitter.
- Test exact 999ms/1000ms boundary (T-0803) with deterministic clock
  instead of using 1100ms to avoid jitter.
- Check GPIO setup return values with \sp!()\ + \xpect()\ to fail fast
  on misconfigured pins instead of silently running with bad GPIO state.
- Align MD-0600 spec text with implementation: internal pull-up is always
  enabled (safe alongside external pull-up; parallel pull-ups simply
  lower effective resistance).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* fix(modem): gate EVENT_BUTTON log on send success, use MockButtonPoll in integration test

- Check send_msg return value before logging EVENT_BUTTON; log a
  warning when USB-CDC write fails (consistent with ESP-NOW RX path).
- Replace the last sleep-based test with a deterministic MockButtonPoll
  that fires on a chosen poll count. All 8 button tests now run in 0.00s.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Alan Jowett <alan.jowett@micro... (continued)

Coverage Stats

251 of 267 new or added lines in 3 files covered. (94.01%)

2 existing lines in 2 files now uncovered.

24706 of 30560 relevant lines covered (80.84%)

201.68 hits per line