KarpelesLab / libwallet / 24785463284

25%

push

github

Web3: unify all signing events into TransactionSignRequest + MessageSignRequest

Every on-chain tx signing flow (eth_sendTransaction,
solana_signTransaction, solana_signAndSendTransaction,
mpurse_signRawTransaction) now emits a single 'transaction_sign'
request type with a rich, chain-agnostic decoded payload:

  TransactionSignValue {
    Chain, Method, From, NetworkId, NetworkName, SizeBytes, Raw,
    DecodedMethod, DecodedArgs, Effects, BalanceChanges, Warnings,
    WillRevert, RevertReason, FeeAmount/Decimals/Symbol,
    EvmTransaction, SolanaUnitsConsumed, SolanaLogs,
    BitcoinInputs/Outputs/FeeSats,
  }

EVM gets the full simulate decoder (effects / balance changes /
warnings / revert) attached at emit time so the host doesn't need
a follow-up Transaction:simulate roundtrip. Solana decodes the
common System Program transfer locally; Bitcoin runs through the
existing simulate decoder.

Every arbitrary-data signing flow (personal_sign,
eth_signTypedData*, solana_signMessage, mpurse_signMessage) now
emits a single 'message_sign' request type with:

  MessageSignValue {
    Chain, Method, From,
    MessageBytes (base64), MessageText (UTF-8 try),
    StructuredData / StructuredPrimaryType / StructuredDomain
      (EIP-712),
    IsSIWE / IsSIWS / SIWEFields (auto-detected SIWE/SIWS),
    Warnings,
  }

The unified approval handler (approveTransactionSign /
approveMessageSign) dispatches by Method, calling the same
chain-specific signing logic the per-method cases used before.

BREAKING CHANGE for Dart consumers:
  - SignRequest, PersonalSignRequest, SignTypedDataRequest,
    SolanaSignMessageRequest, SolanaSignTransactionRequest,
    SolanaSignAndSendTransactionRequest, MpurseSignMessageRequest,
    MpurseSignTransactionRequest are all REMOVED.
  - Pattern-match on TransactionSignRequest or MessageSignRequest
    instead and branch on req.method (and req.chain) for chain-
    specific copy.

Webview integration guide rewritten with the unified switc... (continued)

0 of 691 new or added lines in 5 files covered. (0.0%)

2529 of 12628 relevant lines covered (20.03%)

64.1 hits per line