KarpelesLab / libwallet / 24782637253

25%

Build Type

push

github

Committed by MagicalTux

Commit Message

Web3: unify change_network / add_and_switch_network / chain_switch

Every network switch — whether an explicit
wallet_switchEthereumChain call or an implicit cross-family
action — now flows through a single ChainSwitchRequest. The
payload distinguishes the two shapes via field population:

  • targetNetwork set (+ isNewNetwork bool): dApp named a
    specific chain. UI shows a confirm sheet. isNewNetwork=true
    means the chain isn't in the wallet yet and approval
    implies Add+Switch.
  • candidateNetworks populated, targetNetwork null: cross-
    family action. UI shows a network+account picker.

CandidateAccounts is always populated so the user picks which
account to bind to the dApp on the chosen chain, regardless of
shape.

Server-side refactor:
- requestChainSwitchForTarget(...) drives the target path
- requestChainSwitchPicker(...) drives the picker path
- applyChainSwitchSelection(...) shared post-approval: Save
  (if isNew) + SetCurrent + ensureConnected
- request.go chain_switch approve case now decodes
  ChainSwitchValue and writes a uniform result map the
  callers unpack

BREAKING CHANGE for Dart consumers:
  - ChangeNetworkRequest / AddAndSwitchNetworkRequest are
    removed. Pattern-match on ChainSwitchRequest instead and
    branch on req.targetNetwork != null.
  - AddNetworkRequest is unchanged (pure add, no switch — a
    distinct intent).

Webview integration guide updated with the unified switch
example covering both shapes.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Coverage Stats

0 of 142 new or added lines in 3 files covered. (0.0%)

4 existing lines in 2 files now uncovered.

2529 of 12197 relevant lines covered (20.73%)

65.66 hits per line