SwissDataScienceCenter / renku-data-services / 24777404359

86%

Build Type

push

github

Committed by web-flow

Commit Message

feat(notebook): add secret handling for private registry image pull (#1265)

* feat(notebook): add secret handling for private registry image pull

This secret is created by the admin deploying the platform and is
not user accessible.

* chore: update patch_sesssion for new image pull secret implementation

* fix: add missing None check for private registry secret handling

* chore: simplify secret return handling

When going through this if, the secret is created, thus returning early
is the right action.

Co-authored-by: Flora Thiebaut <flora@leafty.dev>

* chore: make created image pull secret adoption explicit

While this is the default value, this make the intention
clearer with regard to the use of a pre-created secret
such as the one used for the private image registry used
when building images from a private repository.

* feat(builds): validate private/public image prefix to be different

This avoids accidentally sending images built from
private repositories to the same registry used for
public repositories.

* feat: add tests for image prefix validation

* chore: fix format issues

---------

Co-authored-by: Flora Thiebaut <flora@leafty.dev>

Coverage Stats

9 of 10 new or added lines in 3 files covered. (90.0%)

16 existing lines in 5 files now uncovered.

25582 of 29629 relevant lines covered (86.34%)

1.51 hits per line