supabase / supabase-swift / 24770954858

81%

Build Type

push

github

Committed by web-flow

Commit Message

fix(realtime): extract ConnectionManager actor and fix connection lifecycle races (#855)

* refactor(realtime): extract connection lifecycle into ConnectionManager actor

Introduces a dedicated ConnectionManager actor that owns the WebSocket
lifecycle behind an explicit state machine (.disconnected, .connecting,
.connected, .reconnecting). RealtimeClientV2 delegates to it and observes
state changes through a single long-lived task.

Bugs fixed

- Lost phx_join reply after connect: WebSocket.events lazily installed
  onEvent only when the stream was first iterated. Reading conn.events
  synchronously before spawning the message task ensures replies aren't
  dropped.
- status race on connect() return: yielded synchronously from connect()/
  disconnect() with dedup so callers (e.g. RealtimeChannelV2._subscribe)
  don't see stale .connecting.
- Duplicate / missing status transitions: observer no longer double-emits
  on the normal connect path; reconnect path explicitly emits .disconnected
  before the reconnect attempt.
- Concurrent connect() calls: the actor's .connecting case now awaits the
  in-flight task instead of starting a second transport.
- disconnect() did not cancel in-flight connect: now cancels .connecting /
  .reconnecting tasks.
- Double-close on remote-initiated close: handleClose only updates state.
- Reconnect not testable / fired under cancellation: uses _clock.sleep(for:)
  and skips CancellationError.
- Task leaks across reconnects: handleConnected cancels-then-replaces
  messageTask and heartbeatTask.

Public API is unchanged. disconnect() stays synchronous (actor call
dispatched on a detached Task).

Tests

- New ConnectionManagerTests covers the state machine directly.
- 172/172 Realtime tests pass locally.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix(realtime): address code review feedback

- Remove file headers (date conflicts with git blame).
- Mark ConnectionManager.State as Sendable for safe actor bounda... (continued)

Coverage Stats

227 of 277 new or added lines in 2 files covered. (81.95%)

5 existing lines in 1 file now uncovered.

6817 of 8493 relevant lines covered (80.27%)

29.8 hits per line