umputun / tg-spam / 24767742687

83%

Build Type

push

github

Committed by web-flow

Commit Message

Add reaction spam detection (#395)

* add plan: reaction-spam-detection

* feat: add reactionDetector in lib/tgspam

* feat: integrate reactionDetector into Detector (CheckReaction method and config)

* feat: add CheckReaction to Detector interface and OnReaction to SpamFilter

* feat: add reaction routing and procReaction handler to listener

* feat: add CLI flags for reaction spam detection and wire into detector config

* feat: final verification, lint fixes, and README docs for reaction spam detection

* fix: address code review findings for reaction spam detection

- fix: skip reaction removal events (empty NewReaction) to avoid counting removals as spam
- fix: replace ReportBan (msgID=0) with plain text admin notification for reaction bans; the ban already happens immediately and there is no spam message to delete
- refactor: remove dead lastSeen field from reactionHistory, use now.Sub(h.firstSeen) directly
- refactor: remove nil receiver check from reactionDetector.check (CheckReaction already guards)
- test: add NewReaction field to existing procReaction tests to correctly simulate add events
- test: add reaction_removal_not_counted test case
- test: assert CheckReaction not called for approved users, assert it is called for non-approved users
- test: add details assertion to threshold reached tests in reaction_test.go and detector_test.go
- test: improve "threshold exceeded" sub-test to verify count beyond threshold
- docs: add Reaction Spam Detection section to CLAUDE.md
- docs: add approved-user exemption rationale and AllowedUpdates note to README.md

* fix: address code review findings for reaction spam detection

* fix: address code review findings for reaction spam detection

- change sync.RWMutex to sync.Mutex in reactionDetector (write lock only)
- guard newReactionDetector against zero window to prevent silent detection failure

* fix: address code review findings for reaction spam detection

* fix: address code review findings for r... (continued)

Coverage Stats

114 of 133 new or added lines in 6 files covered. (85.71%)

2 existing lines in 1 file now uncovered.

7106 of 8565 relevant lines covered (82.97%)

254.44 hits per line