chideat / valkey-operator / 24766303231

22%

main: 22%

Pull #93

github

fix: render version-conditional configmap directives via SafeVersion

When a Valkey cluster/failover/sentinel is upgrading, the operator
wrote target-version-only directives into the ConfigMap before all
pods were rolled to the new image. If a pod restarted on the old
image before the StatefulSet update reached it, the server could
crash with a 'Bad directive' fatal config error.

CustomConfigs() currently emits no version-gated keys, so the bug
is latent today; this change hardens the same code path that
already broke production for the redis-operator and prevents the
class of failure once any version-conditional directive is added.

- pkg/types/instance.go: add SafeVersion() to Instance
- pkg/version/version.go: add MinKnown helper (skips empty,
  returns lowest)
- internal/valkey/{cluster,failover,sentinel}: implement
  SafeVersion at the instance level, reusing each node's
  existing CurrentVersion()
- internal/builder/{cluster,failover,sentinel}builder/configmap.go:
  derive CustomConfigs from inst.SafeVersion() instead of
  inst.Version()
- mocks updated to satisfy interface

1 of 39 new or added lines in 7 files covered. (2.56%)

4605 of 20629 relevant lines covered (22.32%)

0.26 hits per line