ben-manes / caffeine / #5402

100%

master: 100%

push

github

Record eviction stats before notifying the removal listener consistently

The eviction-recording paths were split between two orderings:
- record-then-notify: evictEntry, doComputeIfAbsent's compute lambda, remap
- notify-then-record: removeNode, put-on-expired/collected,
  remove(key), remove(key, value)

For an executor(Runnable::run) cache with a synchronous RemovalListener that
reads cache.stats(), the same logical eviction event would surface with
evictionCount already incremented at some sites and not yet at others. Not
a documented contract — stats observability inside a listener isn't
guaranteed — but the asymmetry is gratuitous and was caught by review.

Flip the four notify-then-record sites to record-then-notify so every
eviction-recording path uses the same order. Also drop a stray double space
in refreshIfNeeded's containsKey call.

3921 of 3928 branches covered (99.82%)

6 of 6 new or added lines in 1 file covered. (100.0%)

8014 of 8014 relevant lines covered (100.0%)

1.0 hits per line