NVIDIA / nvidia-container-toolkit / 24748865898

43%

main: 44%

push

github

[cudacompat] update version comparison to account for leading zeros in version strings

Any version string passed as an argument to semver.Compare() must be a valid semantic
version. It is common for NVIDIA driver versions to have leading zeros in the MINOR or
PATCH portion of a version string, e.g. 575.57.08. As a result, a call to
semver.Compare("575.57.08", "575.10.10") would incorrectly return -1 because the first
argument is not a valid semantic version.

And from https://pkg.go.dev/golang.org/x/mod/semver#Compare:

'''
An invalid semantic version string is considered less than a valid one.
All invalid semantic version strings compare equal to each other.
'''

Signed-off-by: Christopher Desiniotis <cdesiniotis@nvidia.com>

14 of 14 new or added lines in 1 file covered. (100.0%)

6470 of 14880 relevant lines covered (43.48%)

0.48 hits per line