stacklok / toolhive / 24743186490
66%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 655
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 66.21% (-0.001%) from 66.211%
24743186490

push

github

web-flow 
Compare CRDs against the last release tag, not the rendered chart (#4987)

The advisory workflow added in #4980 rendered both the last-published
OCI chart and the PR tree through helm template, filtered the result
through yq, and fed the concatenated output to crd-schema-checker.
Two problems:

1. crd-schema-checker reads only the first document of a multi-doc
   YAML file, so 11 of 12 CRDs were silently skipped. Breaking changes
   to anything alphabetically after embeddingservers passed the check
   with no findings.
2. The whole render pipeline was needless machinery. files/crds/ is
   the controller-gen source of truth, committed to git, and each file
   already contains exactly one CRD. Rendering the Helm chart only
   added Helm conditionals and a keep annotation, neither of which
   the checker inspects.

Replace the resolve-source → helm pull → helm template → yq split →
checker chain with: fetch the last release tag, iterate over each
file in files/crds/, and run the checker once per pair, diffing the
current file against git show "$TAG:<path>". This also catches CRD
removal via simple filename set difference.

Drops:
- azure/setup-helm entirely
- helm pull from OCI and the release-publish-window concerns
- helm template ×2 and the --set-flags insulation
- yq and the multi-doc filter
- The per-CRD yq split workaround for the checker's multi-doc bug

Verified locally:
- HEAD vs v0.23.0 untouched: exit 0, no findings.
- Simulated mcpgroups description→summary rename: exit 1, two
  NoFieldRemoval findings (v1alpha1 and v1beta1). Before this change
  the same scenario reported "Compatible" because mcpgroups was one
  of the 11 silently-skipped CRDs.

Follows up on #4980.

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

58558 of 88443 relevant lines covered (66.21%)

62.37 hits per line

Coverage Regressions

Lines Coverage ∆ File
4
51.41
 -0.19% pkg/workloads/manager.go
3
79.38
 -0.77% pkg/transport/proxy/httpsse/http_proxy.go
Jobs
ID Job ID Ran Files Coverage
1 24743186490.1 655
66.21
 GitHub Action Run
Source Files on build 24743186490