stacklok / toolhive / 24734423166

66%

push

github

Propagate auth errors through stale cache fallback (#4981)

refreshCache() was returning stale cached data for any API error,
including auth failures (401/403 from registry and OAuth flow timeouts).
Users saw previously-cached registry content with no error after their
credentials expired or the OAuth browser flow timed out.

Fix in two parts:
- auth.Transport.RoundTrip now wraps all Token() errors with
  ErrRegistryAuthRequired, classifying token-acquisition failures as auth
  errors regardless of the underlying cause.
- refreshCache() checks for ErrRegistryAuthRequired/ErrRegistryUnauthorized
  before the stale-cache fallback; transient errors (network, 5xx) still
  degrade gracefully.

Fixes #4950

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

8 of 8 new or added lines in 2 files covered. (100.0%)

58562 of 88443 relevant lines covered (66.21%)

62.74 hits per line