2296
25%

Ran 15 Sep 2016 01:11PM UTC

Jobs 1

Files 516

Run time 27s

Badge

Embed ▾

pending completion

Build # 2296

Build Type

Pull #3103

travis-ci

Committed by

web-flow

Commit Message

Prevent NPE when constructing DataverseRequest for Saved Search #3356

In a refactoring at c10cbd9 we lost the meaning of 0.0.0.0 which was
"Setting address to undefined (0.0.0.0)" so this commit makes the code
clearer.

A note has been added that Saved Search may not play nicely with IP
Groups but this should probably be addressed along with the long list of
other Saved Search issues mentioned in the API Guide: #1364, #1813,
 #1840, #1890, #1939, #2167, #2186, #2053 and #2543

Pull Request Pull Request #3103: Proper detection of IP addresses in JSF context

Coverage Stats

454 of 454 new or added lines in 40 files covered. (100.0%)

4025 of 46832 relevant lines covered (8.59%)

0.09 hits per line

Uncovered Changes

Lines	Coverage	File
37	100.0	src/main/java/edu/harvard/iq/dataverse/RoleAssigneeServiceBean.java
31	100.0	src/main/java/edu/harvard/iq/dataverse/authorization/groups/impl/explicit/ExplicitGroupServiceBean.java
25	100.0	src/main/java/edu/harvard/iq/dataverse/api/Access.java
25	100.0	src/main/java/edu/harvard/iq/dataverse/api/Groups.java
20	100.0	src/main/java/edu/harvard/iq/dataverse/authorization/groups/GroupServiceBean.java
20	100.0	src/main/java/edu/harvard/iq/dataverse/util/json/JsonPrinter.java
19	100.0	src/main/java/edu/harvard/iq/dataverse/search/SearchServiceBean.java
18	100.0	src/main/java/edu/harvard/iq/dataverse/mydata/MyDataFilterParams.java
16	100.0	src/main/java/edu/harvard/iq/dataverse/api/TestApi.java
13	100.0	src/main/java/edu/harvard/iq/dataverse/ManageGroupsPage.java
12	100.0	src/main/java/edu/harvard/iq/dataverse/PermissionServiceBean.java
12	100.0	src/main/java/edu/harvard/iq/dataverse/engine/command/DataverseRequest.java
8	100.0	src/main/java/edu/harvard/iq/dataverse/PermissionsWrapper.java
8	100.0	src/main/java/edu/harvard/iq/dataverse/api/Dataverses.java
8	100.0	src/main/java/edu/harvard/iq/dataverse/mydata/DataRetrieverAPI.java
7	100.0	src/main/java/edu/harvard/iq/dataverse/mydata/MyDataPage.java
6	100.0	src/main/java/edu/harvard/iq/dataverse/authorization/groups/impl/ipaddress/IpGroupsServiceBean.java
5	100.0	src/main/java/edu/harvard/iq/dataverse/authorization/groups/impl/builtin/BuiltInGroupsProvider.java
5	100.0	src/main/java/edu/harvard/iq/dataverse/mydata/RoleTagRetriever.java
4	100.0	src/main/java/edu/harvard/iq/dataverse/DatasetPage.java
4	100.0	src/main/java/edu/harvard/iq/dataverse/search/SearchIncludeFragment.java
3	100.0	src/main/java/edu/harvard/iq/dataverse/authorization/groups/impl/ipaddress/IpGroupProvider.java
2	100.0	src/main/java/edu/harvard/iq/dataverse/DataversePage.java
2	100.0	src/main/java/edu/harvard/iq/dataverse/authorization/groups/impl/ipaddress/ip/IPv4Range.java
2	100.0	src/main/java/edu/harvard/iq/dataverse/mydata/MyDataFinder.java
2	100.0	src/main/java/edu/harvard/iq/dataverse/search/SearchFilesServiceBean.java
1	100.0	src/main/java/edu/harvard/iq/dataverse/DataFile.java
1	100.0	src/main/java/edu/harvard/iq/dataverse/Dataset.java
1	100.0	src/main/java/edu/harvard/iq/dataverse/DataverseRequestServiceBean.java
1	100.0	src/main/java/edu/harvard/iq/dataverse/api/Index.java
1	100.0	src/main/java/edu/harvard/iq/dataverse/api/Search.java
1	100.0	src/main/java/edu/harvard/iq/dataverse/authorization/groups/impl/ipaddress/IpGroup.java
1	100.0	src/main/java/edu/harvard/iq/dataverse/authorization/users/GuestUser.java
1	100.0	src/main/java/edu/harvard/iq/dataverse/search/savedsearch/SavedSearchServiceBean.java

Coverage Regressions

Lines	Coverage	File
29	100.0	src/main/java/edu/harvard/iq/dataverse/api/BuiltinUsers.java
26	100.0	src/main/java/edu/harvard/iq/dataverse/api/Groups.java
22	100.0	src/main/java/edu/harvard/iq/dataverse/authorization/groups/impl/ipaddress/IpGroupsServiceBean.java
13	100.0	src/main/java/edu/harvard/iq/dataverse/api/Access.java
10	100.0	src/main/java/edu/harvard/iq/dataverse/ManageGroupsPage.java
8	100.0	src/main/java/edu/harvard/iq/dataverse/DataversePage.java
7	100.0	src/main/java/edu/harvard/iq/dataverse/DatasetPage.java
6	100.0	src/main/java/edu/harvard/iq/dataverse/PermissionServiceBean.java
5	100.0	src/main/java/edu/harvard/iq/dataverse/authorization/groups/impl/ipaddress/ip/IPv4Range.java
4	100.0	src/main/java/edu/harvard/iq/dataverse/authorization/groups/impl/ipaddress/IpGroup.java
3	100.0	src/main/java/edu/harvard/iq/dataverse/RoleAssigneeServiceBean.java
3	100.0	src/main/java/edu/harvard/iq/dataverse/api/Admin.java
3	100.0	src/main/java/edu/harvard/iq/dataverse/mydata/DataRetrieverAPI.java
3	100.0	src/main/java/edu/harvard/iq/dataverse/authorization/groups/GroupServiceBean.java
3	100.0	src/main/java/edu/harvard/iq/dataverse/engine/command/DataverseRequest.java
2	100.0	src/main/java/edu/harvard/iq/dataverse/PermissionsWrapper.java
2	100.0	src/main/java/edu/harvard/iq/dataverse/mydata/MyDataFilterParams.java
2	100.0	src/main/java/edu/harvard/iq/dataverse/authorization/groups/impl/ipaddress/IpGroupProvider.java
1	100.0	src/main/java/edu/harvard/iq/dataverse/api/Search.java
1	100.0	src/main/java/edu/harvard/iq/dataverse/api/AbstractApiBean.java
1	100.0	src/main/java/edu/harvard/iq/dataverse/DataverseRequestServiceBean.java
1	100.0	src/main/java/edu/harvard/iq/dataverse/engine/command/impl/CreateDataverseCommand.java

Jobs

ID	Job ID	Ran	Files	Coverage
1	2296.1	15 Sep 2016 01:11PM UTC	0	8.59	Travis Job 2296.1

Source Files on build 2296

Detailed source file information is not available for this build.

IQSS / dataverse / 2296
25%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Changes

Coverage Regressions

Jobs

Source Files on build 2296

IQSS / dataverse / 2296 25%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Changes

Coverage Regressions

Jobs

Source Files on build 2296

IQSS / dataverse / 2296
25%

README BADGES
x